wlinator/tux
1
Fork 0
mirror of https://github.com/allthingslinux/tux.git synced 2024-10-03 00:53:12 +00:00
Code Issues Releases Wiki Activity

refactor(cases.py): simplify target conversion by using UserConverter only

Browse source 
fix(cases.py): use ctx.author for moderator assignment to avoid unnecessary conversion
feat(cases.py): add check for moderator type to ensure it's a discord.Member, convert if not
This commit is contained in:
kzndotsh 2024-08-22 02:56:33 +00:00
parent ea1df7797c
commit c2cca276bd
1 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
tux/cogs/moderation/cases.py
View file

@ -150,10 +150,7 @@ class Cases(ModerationCogBase):
await ctx.send("Case not found.", delete_after=30)
return
target = await commands.MemberConverter().convert(
ctx,
str(case.case_target_id),
) or await commands.UserConverter().convert(ctx, str(case.case_target_id))
target = await commands.UserConverter().convert(ctx, str(case.case_target_id))
await self._handle_case_response(ctx, case, "viewed", case.case_reason, target)
@ -233,10 +230,7 @@ class Cases(ModerationCogBase):
await ctx.send("Failed to update case.", delete_after=30, ephemeral=True)
return
target = await commands.MemberConverter().convert(
ctx,
str(case.case_target_id),
) or await commands.UserConverter().convert(ctx, str(case.case_target_id))
target = await commands.UserConverter().convert(ctx, str(case.case_target_id))
await self._handle_case_response(ctx, updated_case, "updated", updated_case.case_reason, target)
@ -266,10 +260,10 @@ class Cases(ModerationCogBase):
"""
if case is not None:
moderator = await commands.MemberConverter().convert(
ctx,
str(case.case_moderator_id),
) or await commands.UserConverter().convert(ctx, str(case.case_moderator_id))
moderator = ctx.author
if not isinstance(moderator, discord.Member):
moderator = await commands.MemberConverter().convert(ctx, str(case.case_moderator_id))
fields = self._create_case_fields(moderator, target, reason)