From af7f3901fc5adfd66d1ce35f59dafcab2ff13576 Mon Sep 17 00:00:00 2001
From: wlinator <git@wlinator.org>
Date: Thu, 22 Aug 2024 23:02:02 +0200
Subject: [PATCH] refactor balance command

---
 config/JSON/strings.json   |  5 ++++-
 modules/economy/balance.py | 20 ++++++++++++--------
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/config/JSON/strings.json b/config/JSON/strings.json
index 16ded9c..20313d0 100644
--- a/config/JSON/strings.json
+++ b/config/JSON/strings.json
@@ -281,5 +281,8 @@
   "xp_lb_field_value": "level: **{0}**\nxp: `{1}/{2}`",
   "xp_level": "Level {0}",
   "xp_progress": "Progress to next level",
-  "xp_server_rank": "Server Rank: #{0}"
+  "xp_server_rank": "Server Rank: #{0}",
+  "balance_cash": "**Cash**: ${0}",
+  "balance_author": "{0}'s wallet",
+  "balance_footer": "Check out /daily"
 }
\ No newline at end of file
diff --git a/modules/economy/balance.py b/modules/economy/balance.py
index e710b79..fb04840 100644
--- a/modules/economy/balance.py
+++ b/modules/economy/balance.py
@@ -1,18 +1,22 @@
-import discord
+from discord.ext import commands
 
 from services.currency_service import Currency
+from lib.constants import CONST
+from lib.embed_builder import EmbedBuilder
 
 
-async def cmd(ctx):
-    # Currency handler
+async def cmd(ctx: commands.Context[commands.Bot]) -> None:
     ctx_currency = Currency(ctx.author.id)
-
     balance = Currency.format(ctx_currency.balance)
 
-    embed = discord.Embed(
-        color=discord.Color.embed_background(),
-        description=f"**Cash**: ${balance}",
+    embed = EmbedBuilder.create_success_embed(
+        ctx,
+        author_text=CONST.STRINGS["balance_author"].format(ctx.author.name),
+        author_icon_url=ctx.author.display_avatar.url,
+        description=CONST.STRINGS["balance_cash"].format(balance),
+        footer_text=CONST.STRINGS["balance_footer"],
+        show_name=False,
+        hide_timestamp=True,
     )
-    embed.set_author(name=f"{ctx.author.name}'s wallet", icon_url=ctx.author.avatar.url)
 
     await ctx.respond(embed=embed)